feat: introduce integration with Gradient AI by mhlgio · Pull Request #6179 · deepset-ai/haystack

mhlgio · 2023-10-26T21:26:45Z

Related Issues

Doesn't have have a related issue.

Proposed Changes:

Gradient AI is a self-managed cloud service for Large Language Models, offering fine-tuning and inference of open-source models and embeddings generation. This PR integrates haystack with Gradient for LLMs and embeddings by adding relevant generators and embedders.

How did you test it?

unit testing,
e2e test based on the RAG test.

Notes for the reviewer

please note that we added a new optional dependency set that needs to be installed with pip install -e .[gradient],
integration requires a generated access token, and tests assume set up environment variables. Please refer to our docs for SDK or for CLI. The CLI can set up environment variables with $(gradient env) command once it's configured.

Checklist

[x] I have read the contributors guidelines and the code of conduct
[x] ~~I have updated the related issue with new insights and changes~~ N/A
[x] I added unit tests and updated the docstrings
[x] I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:. NOTE: to be squashed.
[x] I documented my code
[x] I ran pre-commit hooks and fixed any issue

CLAassistant · 2023-10-26T21:26:52Z

All committers have signed the CLA.

coveralls · 2023-10-27T08:44:07Z

Pull Request Test Coverage Report for Build 6659953333

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.007%) to 50.839%

Files with Coverage Reduction	New Missed Lines	%
utils/context_matching.py	1	95.7%

Totals
Change from base Build 6656519629:	-0.007%
Covered Lines:	13032
Relevant Lines:	25634

💛 - Coveralls

julian-risch

Great to see this PR! Looks quite good to me already. I was able to run the end-to-end test locally. 👍
I have some smaller change requests in the comments below. Please also generate a release note with reno as described here: https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes You can put your text under preview in that note.

mhlgio · 2023-10-31T19:01:30Z

Great to see this PR! Looks quite good to me already. I was able to run the end-to-end test locally. 👍 I have some smaller change requests in the comments below. Please also generate a release note with reno as described here: https://github.com/deepset-ai/haystack/blob/main/CONTRIBUTING.md#release-notes You can put your text under preview in that note.

Added the release notes! let me know

ZanSara · 2023-11-20T09:13:22Z

@mhaligowski Let me try to help you with the CI:

The unit test failure is due to feat: upgrade canals to 0.10.1 #6309, so you need to update the serialization tests to match
Linting is failing because it's still missing the gradientai dependency
the e2e failure can be fixed by merging main into your branch, it's fixed in main.

Let me know if you need more help!

ZanSara · 2023-11-23T10:38:33Z

@mhaligowski here are the fixes: Preemo-Inc#12 Please merge them into your fork and let's see if they help.

One more thing: I noticed that you implemented to_dict, but not from_dict methods yet. Could you implement them? You can check the other embedders to see how it is done.

mhlgio · 2023-11-28T17:27:49Z

applied the fixes, trying to keep up with your main :)

ZanSara

Left a fix

ZanSara · 2023-11-29T15:28:58Z

The preview package is gone, here is the fix:

Suggested change

from haystack.preview import Pipeline, Document

from haystack.components.embedders.gradient_document_embedder import GradientDocumentEmbedder

from haystack.components.embedders.gradient_text_embedder import GradientTextEmbedder

from haystack.preview.document_stores import InMemoryDocumentStore

from haystack.preview.components.writers import DocumentWriter

from haystack.preview.components.retrievers import InMemoryEmbeddingRetriever

from haystack.preview.components.generators.gradient.base import GradientGenerator

from haystack.components.builders.answer_builder import AnswerBuilder

from haystack.components.builders.prompt_builder import PromptBuilder

from haystack.core import Pipeline, Document

from haystack.components.embedders.gradient_document_embedder import GradientDocumentEmbedder

from haystack.components.embedders.gradient_text_embedder import GradientTextEmbedder

from haystack.document_stores import InMemoryDocumentStore

from haystack.components.writers import DocumentWriter

from haystack.components.retrievers import InMemoryEmbeddingRetriever

from haystack.components.generators.gradient.base import GradientGenerator

from haystack.components.builders.answer_builder import AnswerBuilder

from haystack.components.builders.prompt_builder import PromptBuilder

looks like the GradientGenerator wasn't moved out of the preview anyways, so I moved it. All the Gradient tests are passing now in my box!

masci · 2023-12-02T13:22:39Z

Superseded by deepset-ai/haystack-core-integrations#72

mhlgio requested a review from a team as a code owner October 26, 2023 21:26

mhlgio requested review from julian-risch and removed request for a team October 26, 2023 21:26

github-actions Bot added topic:tests topic:dependencies topic:build/distribution 2.x type:documentation Improvements on the docs labels Oct 26, 2023

julian-risch requested changes Oct 27, 2023

View reviewed changes

ZanSara self-requested a review October 27, 2023 12:33

mhlgio requested a review from a team as a code owner October 31, 2023 18:57

mhlgio requested review from dfokina and removed request for a team October 31, 2023 18:57

mhlgio requested a review from julian-risch October 31, 2023 19:21

github-actions Bot added topic:file_converter topic:modeling topic:retriever topic:audio topic:CI proposal labels Nov 6, 2023

mhlgio force-pushed the main branch from 67a9bb6 to 35dc252 Compare November 6, 2023 23:30

github-actions Bot removed topic:file_converter topic:modeling topic:retriever topic:audio topic:CI proposal labels Nov 6, 2023

mhlgio force-pushed the main branch from 6e5950a to 98a4071 Compare November 17, 2023 18:48

mhlgio force-pushed the main branch 2 times, most recently from d924819 to b637865 Compare November 22, 2023 05:33

masci assigned ZanSara Nov 23, 2023

mhlgio force-pushed the main branch from b637865 to 91807a5 Compare November 27, 2023 01:51

github-actions Bot removed the topic:CI label Nov 27, 2023

mhlgio force-pushed the main branch from 91807a5 to 39d7a77 Compare November 28, 2023 02:20

github-actions Bot added the topic:CI label Nov 28, 2023

mhlgio force-pushed the main branch from c31fe79 to fabf8ef Compare November 28, 2023 17:27

ZanSara reviewed Nov 29, 2023

View reviewed changes

lilwilsond2 and others added 13 commits November 29, 2023 10:33

init generator

aa05b97

Gradient embeddings (#2)

86299e9

apply pr requests

e302ccb

add release notes

1db17e7

update texts (#5)

d7838d6

fix tests after rebase

d3ae646

Update add-gradient-ai-integration-045fd476e7d3aa6a.yaml (#9)

8db2b35

apply the changes (#10)

593f9b5

update tests

e21ffa3

install gradient

4d29ee0

more updates

a468cd3

more updates

14581ed

fix e2e test

6b3f107

mhlgio force-pushed the main branch from fabf8ef to 6b3f107 Compare November 29, 2023 19:38

masci mentioned this pull request Dec 1, 2023

Add Gradient Integration deepset-ai/haystack-core-integrations#72

Merged

masci closed this Dec 2, 2023

-from haystack.preview import Pipeline, Document
-from haystack.components.embedders.gradient_document_embedder import GradientDocumentEmbedder
-from haystack.components.embedders.gradient_text_embedder import GradientTextEmbedder
-from haystack.preview.document_stores import InMemoryDocumentStore
-from haystack.preview.components.writers import DocumentWriter
-from haystack.preview.components.retrievers import InMemoryEmbeddingRetriever
-from haystack.preview.components.generators.gradient.base import GradientGenerator
-from haystack.components.builders.answer_builder import AnswerBuilder
-from haystack.components.builders.prompt_builder import PromptBuilder
+from haystack.core import Pipeline, Document
+from haystack.components.embedders.gradient_document_embedder import GradientDocumentEmbedder
+from haystack.components.embedders.gradient_text_embedder import GradientTextEmbedder
+from haystack.document_stores import InMemoryDocumentStore
+from haystack.components.writers import DocumentWriter
+from haystack.components.retrievers import InMemoryEmbeddingRetriever
+from haystack.components.generators.gradient.base import GradientGenerator
+from haystack.components.builders.answer_builder import AnswerBuilder
+from haystack.components.builders.prompt_builder import PromptBuilder

Uh oh!

Conversation

mhlgio commented Oct 26, 2023

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

Uh oh!

CLAassistant commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 27, 2023

Pull Request Test Coverage Report for Build 6659953333

💛 - Coveralls

Uh oh!

julian-risch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mhlgio commented Oct 31, 2023

Uh oh!

ZanSara commented Nov 20, 2023

Uh oh!

ZanSara commented Nov 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhlgio commented Nov 28, 2023

Uh oh!

ZanSara left a comment

Choose a reason for hiding this comment

Uh oh!

ZanSara Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhlgio Nov 29, 2023

Choose a reason for hiding this comment

Uh oh!

masci commented Dec 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

CLAassistant commented Oct 26, 2023 •

edited

Loading

ZanSara commented Nov 23, 2023 •

edited

Loading

ZanSara Nov 29, 2023 •

edited

Loading